Skip to content

Update signing timestamp servers and protocol #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Update signing timestamp servers and protocol #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions installer/build/scripts/Build.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,15 @@ module Builder =
tracefn "Signing MSI"
let certificate = getBuildParam "certificate"
let password = getBuildParam "password"
let timestampServer = "http://timestamp.comodoca.com"
let timeout = TimeSpan.FromMinutes 1.
let timestampServers = ["http://timestamp.digicert.com" ; "http://timestamp.comodoca.com" ;
"http://timestamp.globalsign.com/scripts/timestamp.dll" ; "http://tsa.starfieldtech.com" ;
"http://zeitstempel.dfn.de"]

let sign () =
let sign timestampServer =
let signToolExe = ToolsDir @@ "signtool/signtool.exe"
let args = ["sign"; "/f"; certificate; "/p"; password; "/t"; timestampServer; "/d"; "\"Elasticsearch ODBC Driver\""; "/v"; file] |> String.concat " "
let args = ["sign"; "/debug" ; "/f"; certificate; "/p"; password; "/tr"; timestampServer; "/td" ; "SHA256" ;
"/d"; "\"Elasticsearch ODBC Driver\""; "/v"; file] |> String.concat " "
let redactedArgs = args.Replace(password, "<redacted>")

use proc = new Process()
Expand Down Expand Up @@ -94,8 +97,16 @@ module Builder =
proc.WaitForExit()
proc.ExitCode

let exitCode = sign()
if exitCode <> 0 then failwithf "Signing returned error exit code: %i" exitCode
let mutable notSigned = true
for server in timestampServers do
if notSigned then
let exitCode = sign server
if (exitCode = 0) then
notSigned <- false
else
tracefn "Signing with a timestamp from %s failed with code: %i" server exitCode
if notSigned then failwithf "Signing failed"
else tracefn "Signing succeeded."

// Using DotNetZip due to errors with CMAKE zip files: https://github.com/fsharp/FAKE/issues/775
let unzipFile(zipFolder: string, unzipFolder: string) =
Expand Down