Fix varchar limitation when max-len-attr is set #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the result rewriting of the SQLColumns due to varchar limit setting in case the SQL_ATTR_MAX_LENGTH attribute is set. The attribute changes the lenght indicator given by SQLGetData to the value of the attribute (which a setting application expects). Since the rewriting is serialized on the statment, simply reset this attribute's value while doing the writing. The types of the columns in the rewritten result are also corrected (they were copied from ES/SQL output, which are wrong and need fixing).
droberts195
reviewed
Mar 27, 2020
driver/catalogue.c
Outdated
| wstr_st *lim = &HDRH(stmt)->dbc->varchar_limit_str; | ||
|
|
||
| /* save and reset SQL_ATTR_MAX_LENGTH attribute, it'll interfere with | ||
| * reading lenght of avail data with SQLGetData() otherwise. */ |
Collaborator
Author
There was a problem hiding this comment.
I'll have to install a precommit check for this one. Thanks, fixed them all.
s/lenght/legth/
bpintea
added a commit
that referenced
this pull request
Mar 30, 2020
* Fix varchar limitation when max-len-attr is set This fixes the result rewriting of the SQLColumns due to varchar limit setting in case the SQL_ATTR_MAX_LENGTH attribute is set. The attribute changes the lenght indicator given by SQLGetData to the value of the attribute (which a setting application expects). Since the rewriting is serialized on the statment, simply reset this attribute's value while doing the writing. The types of the columns in the rewritten result are also corrected (they were copied from ES/SQL output, which are wrong and need fixing). (cherry picked from commit c6556af)
bpintea
added a commit
that referenced
this pull request
Mar 30, 2020
* Fix varchar limitation when max-len-attr is set This fixes the result rewriting of the SQLColumns due to varchar limit setting in case the SQL_ATTR_MAX_LENGTH attribute is set. The attribute changes the lenght indicator given by SQLGetData to the value of the attribute (which a setting application expects). Since the rewriting is serialized on the statment, simply reset this attribute's value while doing the writing. The types of the columns in the rewritten result are also corrected (they were copied from ES/SQL output, which are wrong and need fixing). (cherry picked from commit c6556af)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the result rewriting of the SQLColumns due to varchar limit
setting in case the SQL_ATTR_MAX_LENGTH attribute is set. The attribute
changes the length indicator given by SQLGetData to the value of the
attribute (which a setting application expects).
Since the rewriting is serialized on the statement, simply reset this
attribute's value while doing the writing.
The types of the columns in the rewritten result are also corrected
(they were copied from ES/SQL output, which are wrong and need fixing).