Sign DLL files to be added into the MSI #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far only the MSI had been considered for signing. This commit adds the logic to also sign the DLL files that are going to be packed into the MSI. The commit adds the code to find all the DLL files within the directory unpackaged from the ZIP file produced by the build, then sign them with same function used to sign the MSI file.
codebrain
approved these changes
Nov 26, 2019
bpintea
added a commit
that referenced
this pull request
Nov 28, 2019
So far only the MSI had been considered for signing. This commit adds the logic to also sign the DLL files that are going to be packed into the MSI. The commit adds the code to find all the DLL files within the directory unpackaged from the ZIP file produced by the build, then sign them with same function used to sign the MSI file. (cherry picked from commit 89ec656)
bpintea
added a commit
that referenced
this pull request
Dec 2, 2019
So far only the MSI had been considered for signing. This commit adds the logic to also sign the DLL files that are going to be packed into the MSI. The commit adds the code to find all the DLL files within the directory unpackaged from the ZIP file produced by the build, then sign them with same function used to sign the MSI file. (cherry picked from commit 89ec656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far only the MSI had been considered for signing. This commit adds
the logic to also sign the DLL files that are going to be packed into
the MSI.
The PR adds the code to find all the DLL files within the directory
unpackaged from the ZIP file produced by the build, then sign them with
same function used to sign the MSI file.