SQLDriverConnect: fix handling of output connection string buffer #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the application provides an output buffer for the constructed connection string, the driver will currently return an error and thus fail the connection. The correct handling is however to apply truncation but return the number of characters available without trunctation. This commit works around swprintf() returning an error code, but otherwise correctly 0-terminating the destination buffer and not setting the errno.
bpintea
added a commit
that referenced
this pull request
Nov 13, 2019
If the application provides an output buffer for the constructed connection string, the driver will currently return an error and thus fail the connection. The correct handling is however to apply truncation but return the number of characters available without trunctation. This commit works around swprintf() returning an error code, but otherwise correctly 0-terminating the destination buffer and not setting the errno. (cherry picked from commit ef5dccb)
bpintea
added a commit
that referenced
this pull request
Nov 13, 2019
If the application provides an output buffer for the constructed connection string, the driver will currently return an error and thus fail the connection. The correct handling is however to apply truncation but return the number of characters available without trunctation. This commit works around swprintf() returning an error code, but otherwise correctly 0-terminating the destination buffer and not setting the errno. (cherry picked from commit ef5dccb)
bpintea
added a commit
that referenced
this pull request
Dec 4, 2019
If the application provides an output buffer for the constructed connection string, the driver will currently return an error and thus fail the connection. The correct handling is however to apply truncation but return the number of characters available without trunctation. This commit works around swprintf() returning an error code, but otherwise correctly 0-terminating the destination buffer and not setting the errno. (cherry picked from commit ef5dccb) Merge changed to use 6.8 ES/SQL data types (test/connected_dbc.*).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the application provides an output buffer for the constructed
connection string, the driver will currently return an error and thus
fail the connection. The correct handling is however to apply truncation
but return the number of characters available without truncation.
This PR works around swprintf() returning an error code, but
otherwise correctly 0-terminating the destination buffer and not setting
the errno.