Skip to content

Conversation

@bpintea
Copy link
Collaborator

@bpintea bpintea commented Jul 10, 2019

This PR is simply a partial revert of #162, switching back to debug-level logging for
setting of descriptor fields: one result-set accessing mode requires setting/resetting
of the descriptors for every single cell in a result set, making
info-logging impractical.

Partial revert of elastic#162, simply switching back to debug-level logging for
setting of descriptor fields only: SQLGetData requires setting/resetting
of the descriptors for every single cell in a result set, making
info-logging impractical.
Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpintea bpintea merged commit 7f794ee into elastic:master Jul 11, 2019
@bpintea bpintea deleted the enh/dbg_for_desc_settings branch July 11, 2019 08:47
bpintea added a commit that referenced this pull request Jul 11, 2019
Partial revert of #162, simply switching back to debug-level logging for
setting of descriptor fields only: SQLGetData requires setting/resetting
of the descriptors for every single cell in a result set, making
info-logging impractical.

(cherry picked from commit 7f794ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants