Add types to 'knn_search' API #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
force-pushed
the
knn-search
branch
from
c867a57 to
9013c13
Compare
delvedor
reviewed
Oct 21, 2021
sethmlarson
commented
Oct 21, 2021
|
@sethmlarson thanks for tackling this! In addition to
They are not available as query parameters, unlike in the |
jtibshirani
reviewed
Oct 21, 2021
delvedor
reviewed
Oct 25, 2021
Contributor
Author
|
@delvedor @jtibshirani I believe I've resolved the review comments. Let me know if things look good. |
Contributor
Author
|
This PR can't be backported because the JSON specs haven't been updated in some time on 7.x/7.16. |
|
@sethmlarson kNN search will only be available in ES 8.0, so it won't appear in the spec on 7.x. |
Contributor
Author
|
@jtibshirani That explains it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
knn_searchAPI. @jtibshirani could you take a look and let me know if there are missing parameters? I looked over the PRs and saw some chatter about docvalues_fields, stored_fields, etc but didn't see those values in the query parameter section of the API so went with onlyrouting.