Skip to content

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarson
Copy link
Contributor Author

sethmlarson commented Jul 19, 2022

Since this includes a breaking change in making the responses' indices property optional I won't backport this one automatically.

@sethmlarson sethmlarson requested review from a team and removed request for stevejgordon July 26, 2022 17:48
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
snapshot.cleanup_repository 🟢 3/3 3/3
snapshot.clone 🟢 5/5 5/5
snapshot.create_repository 🟢 26/26 26/26
snapshot.create 🟢 26/26 26/26
snapshot.delete_repository 🟢 10/10 10/10
snapshot.delete 🟢 20/20 20/20
snapshot.get_repository 🟢 19/19 19/19
snapshot.get 🟢 13/13 13/13
snapshot.repository_analyze 🟠 Missing type Missing type
snapshot.restore 🟢 5/5 5/5
snapshot.status 🟢 2/2 2/2
snapshot.verify_repository 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants