Update Faraday on 6.x #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrating to Faraday 1.0 means we check with `adapter` to see which one has been selected. I also changed the order in which the given block is ran. There's a case where one of the adapter libraries could be loaded and an adapter is passed in with the block, but `__auto_detect_adapter` would overwrite this. So the block is now ran last.
picandocodigo
force-pushed
the
update_faraday_6.x
branch
from
b0113ce to
8033aaa
Compare
picandocodigo
force-pushed
the
update_faraday_6.x
branch
from
8033aaa to
519355d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #808