Skip to content

Conversation

taylorthurlow
Copy link
Contributor

@taylorthurlow taylorthurlow commented Jan 16, 2020

Faraday recently released 1.0, and elasticsearch-transport was on 0.xx. Breaking changes in 1.0 plus the gemspec allowing the update to 1.x can cause unclear problems.

Related issue: #751

Faraday recently released 1.0, and elasticsearch-transport was on 0.xx.
Breaking changes in 1.0 plus the gemspec allowing the update to 1.x can
cause unclear problems.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@taylorthurlow
Copy link
Contributor Author

Looks like the failing Travis build is unrelated, it's happened before.

@picandocodigo
Copy link
Member

Thank you for this contribution @taylorthurlow!
Yes, the build is failing right now, I'm still working on it 😁

I'm going to merge this in and backport it to 6.x and 7.x and start using 1.0+ for master.

@picandocodigo
Copy link
Member

jenkins run the tests please

@cosmo0920
Copy link
Contributor

cosmo0920 commented Jan 24, 2020

@picandocodigo How log does it take to be released this patch for 7.x?
I couldn't find 7.x version which is included Faraday 1.0 issue patch.

@picandocodigo
Copy link
Member

@cosmo0920 This patch will be included in elasticsearch-ruby 7.5.0. I'm currently working on that after releasing 6.8.1 with the fix.

Thank you for your patience!

@cosmo0920
Copy link
Contributor

Oh, I see.
Thank you for your hard work. 😁

@gaochundong
Copy link

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants