[CLIENT] Make Typhoeus work out of the box #131
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janko
force-pushed
the
typhoeus-out-of-the-box
branch
from
d6a9899 to
71d4245
Compare
Contributor
|
@janko-m I'm not a huge fan of |
janko
force-pushed
the
typhoeus-out-of-the-box
branch
from
71d4245 to
34fb0b7
Compare
Contributor
|
@janko-m Hi, sorry for "chewing" on it for so long :) Even after some time, I'd rather risk somebody makes the mistake you did, than requiring files from within conditionals within methods... I had some really bad experiences with that when some libraries did that... |
Author
|
Sure, I understand, you already mention |
Contributor
|
Great!, thanks for understanding! |
rafayqayyum
pushed a commit
to rafayqayyum/elasticsearch-ruby
that referenced
this pull request
Mar 4, 2025
rafayqayyum
pushed a commit
to rafayqayyum/elasticsearch-ruby
that referenced
this pull request
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wanted to use Typhoeus for Elasticsearch, but I got
The option: disable_ssl_peer_verification is invalid. (Ethon::Errors::InvalidOption). This is because I forgot to require the official adapter (typhoeus/adapters/faraday). I was thinking that it would be make sense if it was automatically required, so that it works out-of-the-box.By the way, I started using Elasticsearch only a week ago, and I'm really loving the separation of gems you guys made for Elasticsearch, it's just so easy to find everything.