improve and correct documentation on indices analyze api #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmi
force-pushed
the
master
branch
4 times, most recently
from
249bb53 to
d445013
Compare
Contributor
There was a problem hiding this comment.
I think this addition is great, we should add it with the @note YARDoc notation.
Contributor
|
@s01ipsist Terribly sorry to let this slip -- I like the addition, can you please sign the CLA so I can proceed with merging this? |
kkirsche
added a commit
to kkirsche/elasticsearch-ruby
that referenced
this pull request
Feb 17, 2015
Correct and extend documentation on indices.analyze API — equivalent to elastic#109
karmi
pushed a commit
that referenced
this pull request
Feb 21, 2015
Correct and extend documentation on indices.analyze API. Equivalent to pull request #109 by @s01ipsist. Closes #135
Contributor
|
@s01ipsist I'm terribly sorry to let this slip, I merged the same patch from #135 right now. My apologies -- I'd probably leave it at it, I've at least added your Github nickname to the commit message and force pushed the commit. |
Contributor
|
Closed by d6d77dc |
Contributor
|
@s01ipsist This has been added in d6d77dc, terribly sorry about forgetting about this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this error
org.elasticsearch.common.netty.handler.codec.frame.TooLongFrameException: An HTTP line is larger than 4096 bytes.analyzing a long piece of text.
Using the :body parameter this works fine. I thought it worth adding a note to the docs.
The change of documented type of the :body parameter is actually already covered by a test in analyze_test.rb
subject.indices.analyze :body => 'foo'