Renamed the timeout parameter in docstring to request_timeout as the @query_params decorator expects request_timeout.
#891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the @query_params decorator expects `request_timeout`. The `timeout` parameter in docstring is misleading for following methods in elasticsearch.client.indices.py, renamed this param in docstring as `request_timeout`: 1. create 2. open 3. close 4. delete 5. put_mapping 6. put_alias 7. update_aliases 8. delete_alias 9. put_template 10. delete_template 11. shrink 12. rollover
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Jenkins test this please |
|
@jubins Thanks for the patch, but I was doing just a quick check at the decorator for the first docstring you patched and the decorator is using |
1. Changed the `timeout` to `request_timeout` in the @query_params decorator as request_timeout in not getting escaped utils.py. 2. Re-tested the changed methods.
|
jenkins test this please |
|
@jubins Could you please rebase this PR, I'll have jekins run the tests again afterwards. Thanks |
Hi Nick, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
timeoutparameter in docstring is misleading for following methods in elasticsearch.client.indices.py, renamed this param in docstring asrequest_timeout: