Skip to content

[Backport 7.12] Adds back additional information when running our tests #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2021
Merged

[Backport 7.12] Adds back additional information when running our tests #5351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/Tests.Core/Client/Settings/TestConnectionSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ private void ApplyTestSettings() =>
.ConnectionLimit(ConnectionLimitDefault)
.OnRequestCompleted(r =>
{
//r.HttpMethod;


if (!r.DeprecationWarnings.Any()) return;

var q = r.Uri.Query;
Expand Down
27 changes: 18 additions & 9 deletions tests/Tests.Core/Xunit/NestXunitRunOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Runtime.InteropServices;
using System.Text;
using Elastic.Elasticsearch.Xunit;
using Tests.Configuration;
Expand All @@ -28,16 +29,13 @@ public NestXunitRunOptions()
Generators.Initialize();
}

public override void OnBeforeTestsRun()
{
//TestConfiguration.Instance.DumpConfiguration();
}
public override void OnBeforeTestsRun() => TestConfiguration.Instance.DumpConfiguration();

public override void OnTestsFinished(Dictionary<string, Stopwatch> clusterTotals, ConcurrentBag<Tuple<string, string>> failedCollections)
{
// DumpClusterTotals(clusterTotals);
// DumpSeenDeprecations();
// DumpFailedCollections(failedCollections);
DumpClusterTotals(clusterTotals);
DumpSeenDeprecations();
DumpFailedCollections(failedCollections);
}

private static void DumpClusterTotals(Dictionary<string, Stopwatch> clusterTotals)
Expand All @@ -60,7 +58,18 @@ private static void DumpSeenDeprecations()

private static void DumpFailedCollections(ConcurrentBag<Tuple<string, string>> failedCollections)
{
if (failedCollections.Count <= 0) return;
if (failedCollections.Count <= 0)
{
var config = TestConfiguration.Instance;
var runningIntegrations = config.RunIntegrationTests;
Console.ForegroundColor = ConsoleColor.Yellow;
Console.WriteLine("---Reproduce: -----");
var reproduceLine = ReproduceCommandLine(failedCollections, config, runningIntegrations);
Console.WriteLine(reproduceLine);
Console.WriteLine("---------------");
Console.ResetColor();
return;
};

Console.ForegroundColor = ConsoleColor.Red;
Console.WriteLine("Failed collections:");
Expand Down Expand Up @@ -97,7 +106,7 @@ private static string ReproduceCommandLine(ConcurrentBag<Tuple<string, string>>
bool runningIntegrations
)
{
var sb = new StringBuilder(".\\build.bat ")
var sb = new StringBuilder(RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? ".\\build.bat " : "./build.sh ")
.Append("seed:").Append(config.Seed).Append(" ");

AppendConfig(nameof(RandomConfiguration.SourceSerializer), config.Random.SourceSerializer, sb);
Expand Down