Serialize Epoch milliseconds as a string #4996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the DateTimeOffsetEpochMillisecondsFormatter and NullableDateTimeOffsetEpochMillisecondsFormatter to serialize epoch milliseconds as a string instead of a number. Add additional parameters to integration tests to assert the change is valid where used.
Mpdreamz
approved these changes
Sep 2, 2020
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Lgtm, I yearn for the days when we can have one converter or even rely on the defaults though.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2020
This commit updates the DateTimeOffsetEpochMillisecondsFormatter and NullableDateTimeOffsetEpochMillisecondsFormatter to serialize epoch milliseconds as a string instead of a number. Add additional parameters to integration tests to assert the change is valid where used.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2020
This commit updates the DateTimeOffsetEpochMillisecondsFormatter and NullableDateTimeOffsetEpochMillisecondsFormatter to serialize epoch milliseconds as a string instead of a number. Add additional parameters to integration tests to assert the change is valid where used.
russcam
added a commit
that referenced
this pull request
Sep 3, 2020
This commit updates the DateTimeOffsetEpochMillisecondsFormatter and NullableDateTimeOffsetEpochMillisecondsFormatter to serialize epoch milliseconds as a string instead of a number. Add additional parameters to integration tests to assert the change is valid where used. Co-authored-by: Russ Cam <[email protected]>
russcam
added a commit
that referenced
this pull request
Sep 3, 2020
This commit updates the DateTimeOffsetEpochMillisecondsFormatter and NullableDateTimeOffsetEpochMillisecondsFormatter to serialize epoch milliseconds as a string instead of a number. Add additional parameters to integration tests to assert the change is valid where used. Co-authored-by: Russ Cam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the DateTimeOffsetEpochMillisecondsFormatter
and NullableDateTimeOffsetEpochMillisecondsFormatter to serialize
epoch milliseconds as a string instead of a number. Add additional
parameters to integration tests to assert the change is valid
where used.