Skip to content

Conversation

@Mpdreamz
Copy link
Member

Downloads the spec and generates the low level client

Will follow up once merged with a PR for the high level client

@Mpdreamz Mpdreamz changed the base branch from 7.x to 7.6 February 12, 2020 08:48
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation url changes to use http instead of https simply result in the request being redirected by a 301 status code on the server.

Do we want to implement a global replace rule to swap out for https?

@Mpdreamz
Copy link
Member Author

Updated so that the links in code are always https:// even if the docs indicate http://

@Mpdreamz Mpdreamz requested a review from codebrain February 18, 2020 14:10
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mpdreamz Mpdreamz merged commit afa9791 into 7.6 Feb 19, 2020
@Mpdreamz Mpdreamz deleted the feature/7.6/code-gen branch February 19, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants