Use correct IJsonFormatter<T> in attributes #4383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where VerifyRepositoryResponse was attributed with the wrong formatter type in JsonFormatterAttribute applied at the type level. Utf8Json's formatters are strongly typed for speed at the cost of less flexibility. Fix other cases where the incorrect formatter type is used, and introduce a convention test to assert that types and their properties attributed with JsonFormatterAttribute use the correct formatter type. Fixes #4382
Contributor
Author
|
opened #4385 to tackle failing enrich policy test, which are unrelated to this PR. |
russcam
added a commit
that referenced
this pull request
Feb 12, 2020
This commit fixes a bug where VerifyRepositoryResponse was attributed with the wrong formatter type in JsonFormatterAttribute applied at the type level. Utf8Json's formatters are strongly typed for speed at the cost of less flexibility. Fix other cases where the incorrect formatter type is used, and introduce a convention test to assert that types and their properties attributed with JsonFormatterAttribute use the correct formatter type. Fixes #4382 (cherry picked from commit 635f162)
Contributor
Author
|
ported to master ec50401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where VerifyRepositoryResponse was attributed
with the wrong formatter type in JsonFormatterAttribute applied at the type level.
Utf8Json's formatters are strongly typed for speed at the cost of less flexibility.
Fix other cases where the incorrect formatter type is used, and introduce a
convention test to assert that types and their properties attributed with
JsonFormatterAttribute use the correct formatter type.
Fixes #4382