Implement SLM Execute Retention API #4258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Dec 10, 2019
Mpdreamz
requested changes
Dec 10, 2019
russcam
suggested changes
Dec 13, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
I've left a comment about the type names
| } | ||
|
|
||
| ///<summary>Request options for ExecuteRetention <para>https://www.elastic.co/guide/en/elasticsearch/reference/current/slm-api-execute-retention.html</para></summary> | ||
| public class ExecuteRetentionRequestParameters : RequestParameters<ExecuteRetentionRequestParameters> |
Contributor
There was a problem hiding this comment.
Should the type name(s) be ExecuteSnapshotLifecycleRetention* ? The shortened method names are fine, because they reflect what is in the spec and are namespaced on SnapshotLifecycleManagement, but with the types, these live in the root Nest namespace, which feels like we ought to be more explicit to avoid naming collisions now and in future.
Contributor
Author
|
Ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: elastic/elasticsearch#47405