Add SLM Start/Stop/Status APIs #4245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly in generator.
Mpdreamz
reviewed
Dec 2, 2019
src/CodeGeneration/ApiGenerator/RestSpecification/XPack/slm.get_status.json
Show resolved
Hide resolved
russcam
suggested changes
Dec 9, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
Looks like there are some failing integration tests
Member
|
russcam
suggested changes
Dec 13, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
I've left some comments.
I think the Slm in type names should be expanded out to SnapshotLifecycle, to match the other existing SLM APIs released. I think the shortened method names are fine, as they are namespaced and reflect the names in the spec.
src/Elasticsearch.Net/Api/RequestParameters/RequestParameters.SnapshotLifecycleManagement.cs
Outdated
Show resolved
Hide resolved
src/Elasticsearch.Net/Api/RequestParameters/RequestParameters.SnapshotLifecycleManagement.cs
Outdated
Show resolved
Hide resolved
src/Elasticsearch.Net/Api/RequestParameters/RequestParameters.SnapshotLifecycleManagement.cs
Outdated
Show resolved
Hide resolved
russcam
approved these changes
Dec 13, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM.
We had a conversation about whether the types should be SnapshotLifecycle* or SnapshotLifecycleManagement* for start, stop and status APIs. We agreed that including Management was probably a good idea in this instance, as the APIs relate to the plugin as a whole.
codebrain
added a commit
that referenced
this pull request
Dec 13, 2019
(cherry picked from commit d4c6b80)
Contributor
Author
|
Ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.