Remove lat lon bound checks from GeoLocation #4225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates: elastic/elasticsearch#43893 This commit removes the bound checks on latitude and longitude on GeoLocation (and the derived GeoCoordinate), to allow values outside of the -90 to 90, and -180 to 180 ranges, respecitvely.
codebrain
reviewed
Nov 15, 2019
|
|
||
| return null; | ||
| } | ||
| // TODO: Remove in 8.0 as without bounds checks, provides no value |
russcam
added a commit
that referenced
this pull request
Nov 15, 2019
Relates: elastic/elasticsearch#43893 This commit removes the bound checks on latitude and longitude on GeoLocation (and the derived GeoCoordinate), to allow values outside of the -90 to 90, and -180 to 180 ranges, respecitvely. (cherry picked from commit 29d68b2)
russcam
added a commit
that referenced
this pull request
Nov 15, 2019
Relates: elastic/elasticsearch#43893 This commit removes the bound checks on latitude and longitude on GeoLocation (and the derived GeoCoordinate), to allow values outside of the -90 to 90, and -180 to 180 ranges, respecitvely. (cherry picked from commit 29d68b2)
Contributor
Author
|
ported to 7.4 and master; port to master removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: elastic/elasticsearch#43893
This commit removes the bound checks on latitude and longitude on GeoLocation (and the derived GeoCoordinate), to allow values outside of the -90 to 90, and -180 to 180 ranges, respecitvely.