Implement shape queries. #4155
Merged
Implement shape queries. #4155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Oct 17, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Generally looks good to me, needs some skipversion attributes and a pass over the docs.
| if (q.Field.IsConditionless()) | ||
| return true; | ||
|
|
||
| switch (q.Shape) |
src/Tests/Tests/QueryDsl/Specialized/Shape/ShapeQueryUsageTests.cs
Outdated
Show resolved
Hide resolved
codebrain
added a commit
that referenced
this pull request
Oct 18, 2019
codebrain
added a commit
that referenced
this pull request
Oct 18, 2019
Contributor
Author
|
Ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR: #4154
Implements: elastic/elasticsearch#45108