Fix test for random initialized node (#4134) #4144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was using a local method that yielded a single pool while later .Take(50) was requested on this sequence. This always yields an enumeration with 1 element which increases the chances for the assertion to turn false. Rather than relying on Thread.Sleep to create different seeded randoms the StaticConnectionPool now defines a protected constructor that allows one to pass in a seed value. (cherry picked from commit 9734f04)
Contributor
Author
|
port to master of #4134 |
Mpdreamz
requested changes
Oct 15, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
I think two properties gained public setters again inadvertently other than that LGTM, thanks for doing the forward port!
|
|
||
| /// <inheritdoc /> | ||
| public bool UsingSsl { get; } | ||
| public bool UsingSsl { get; set; } |
Member
There was a problem hiding this comment.
Suggested change
| public bool UsingSsl { get; set; } | |
| public bool UsingSsl { get; } |
Contributor
Author
There was a problem hiding this comment.
Should be a private setter
| } | ||
|
|
||
| protected IDateTimeProvider DateTimeProvider { get; } | ||
| protected IDateTimeProvider DateTimeProvider { get; set; } |
Member
There was a problem hiding this comment.
Suggested change
| protected IDateTimeProvider DateTimeProvider { get; set; } | |
| protected IDateTimeProvider DateTimeProvider { get; } |
Contributor
Author
There was a problem hiding this comment.
Should be a private setter
Contributor
Author
|
Would you mind taking a look again @Mpdreamz |
Member
|
@russcam compilation failed on CI |
Fat-fingered a 'B' when running a build with CTRL + SHIFT + b...
Contributor
Author
|
D'oh, fat fingered a |
Contributor
Author
|
Merging this in; failing tests are not related to this change, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was using a local method that yielded a single pool while later .Take(50)
was requested on this sequence. This always yields an enumeration with 1 element
which increases the chances for the assertion to turn false.
Rather than relying on Thread.Sleep to create different seeded randoms the StaticConnectionPool
now defines a protected constructor that allows one to pass in a seed value.
(cherry picked from commit 9734f04)