Build DebugInformation uri and method from Request or ApiCallDetails #4077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes how DebugInformation is built in ElasticsearchClientException to use either Request or ApiCallDetails to retrieve the Uri and method of the request. There are some usages of ElasticsearchClientException where the Request property is not set, such as Throw() method in BulkAllObservable. Fixes #3687
Closed
Mpdreamz
approved these changes
Sep 23, 2019
Member
|
LGTM sorry for taking a while to get to this one |
russcam
added a commit
that referenced
this pull request
Sep 27, 2019
…4077) * Build DebugInformation uri and method from Request or ApiCallDetails This commit changes how DebugInformation is built in ElasticsearchClientException to use either Request or ApiCallDetails to retrieve the Uri and method of the request. There are some usages of ElasticsearchClientException where the Request property is not set, such as Throw() method in BulkAllObservable. Fixes #3687 (cherry picked from commit 4787e27)
russcam
added a commit
that referenced
this pull request
Sep 27, 2019
…4077) * Build DebugInformation uri and method from Request or ApiCallDetails This commit changes how DebugInformation is built in ElasticsearchClientException to use either Request or ApiCallDetails to retrieve the Uri and method of the request. There are some usages of ElasticsearchClientException where the Request property is not set, such as Throw() method in BulkAllObservable. Fixes #3687 (cherry picked from commit 4787e27)
Contributor
Author
|
ported to master and 6.x |
russcam
added a commit
that referenced
this pull request
Oct 1, 2019
…4077) * Build DebugInformation uri and method from Request or ApiCallDetails This commit changes how DebugInformation is built in ElasticsearchClientException to use either Request or ApiCallDetails to retrieve the Uri and method of the request. There are some usages of ElasticsearchClientException where the Request property is not set, such as Throw() method in BulkAllObservable. Fixes #3687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how DebugInformation is built in ElasticsearchClientException to use either Request
or ApiCallDetails to retrieve the Uri and method of the request. There are some usages of ElasticsearchClientException
where the Request property is not set, such as Throw() method in BulkAllObservable.
Fixes #3687