Fix CI resolving to bundled JDK #3987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting elasticsearch and forces it on the Process instance
…d any body if no body is documented we relied on serializing empty bodies but the server is now (rightfully) much stricter here. elastic/elasticsearch#44902
russcam
reviewed
Aug 7, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
What was the driver for introducing SupportsBody?
src/CodeGeneration/ApiGenerator/Views/LowLevel/RequestParameters/RequestParameters.cshtml
Show resolved
Hide resolved
Member
Author
|
This will now raise an error if a body was sent but was left unconsumed by the server which is a great addition.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works currently works locally but not on azure devops where it falls back to the installed JRE8 which the snapshots build no longer accepts as a valid java version.
This PR updates abstractions to version that prints JAVA_HOME just before starting elasticsearch and forces it on the Process instance