Skip to content

Add System.Diagnostics.DiagnosticSource reference for NetStandard 2.0 #3948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Add System.Diagnostics.DiagnosticSource reference for NetStandard 2.0 #3948

merged 1 commit into from
Jul 16, 2019

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Jul 12, 2019

Fixes #3945

@russcam russcam mentioned this pull request Jul 12, 2019
Closed
@russcam russcam requested a review from codebrain July 16, 2019 03:07
codebrain
codebrain approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 44e9836 into master Jul 16, 2019
russcam added a commit that referenced this pull request Jul 16, 2019
@russcam
Add System.Diagnostics.DiagnosticSource reference for NetStandard 2.0 (…
4e8a2c5 
…#3948)

Fixes #3945

(cherry picked from commit 44e9836)
russcam added a commit that referenced this pull request Jul 18, 2019
@russcam
Add System.Diagnostics.DiagnosticSource reference for NetStandard 2.0 (…
25645c0 
…#3948)

Fixes #3945

(cherry picked from commit 44e9836)
codebrain pushed a commit that referenced this pull request Jul 19, 2019
@russcam
Add System.Diagnostics.DiagnosticSource reference for NetStandard 2.0 (…
8295dfe 
…#3948)

Fixes #3945

(cherry picked from commit 44e9836)
@russcam russcam deleted the fix/3945 branch July 24, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@codebrain codebrain codebrain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NEST requires explicit installation of System.Diagnostics.DiagnosticSource nuget.

3 participants

@russcam @codebrain