Skip to content

Conversation

@codebrain
Copy link
Contributor

No description provided.

russcam and others added 2 commits June 26, 2019 15:39
This commit updates the API generator to generate APIs asynchronously
and to await all IncludeAsync calls. Not await'ing these calls results in
Razorlight template compilation errors, as the RoslynCompilationService
used by the RazorLightEngine type flags these as warnings, which are
treated as errors.
@codebrain codebrain requested a review from Mpdreamz June 26, 2019 12:49
@Mpdreamz Mpdreamz mentioned this pull request Jun 27, 2019
15 tasks
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebrain codebrain merged commit 28f6a5e into 7.x Jun 27, 2019
@russcam russcam deleted the fix/options-obsolete branch July 2, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants