Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Jun 24, 2019

This commit deletes the Indices Upgrade APIs. Both the GET and POST versions of the API are not useful since the upgrade from 2.x to 5.x and will be removed from the REST specs. Taking the opportunity now to remove them in 7.x .NET clients.

Closes #3854

This commit deletes the Indices Upgrade APIs. Both the GET and POST versions of the API are not useful since the upgrade from 2.x to 5.x and will be removed from the REST specs. Taking the opportunity now to remove them in 7.x .NET clients.

Closes #3854
@Mpdreamz
Copy link
Member

One test failure:

[xUnit.net 00:00:16.3040902]     Tests.CodeStandards.Responses.ResponsePropertyCollectionsShouldBeReadOnly [FAIL]
Failed   Tests.CodeStandards.Responses.ResponsePropertyCollectionsShouldBeReadOnly
Error Message:
 Expected collection to be empty, but found {"Elasticsearch.Net.DynamicDictionary.Keys is of type ICollection`1", "Elasticsearch.Net.DynamicDictionary.Values is of type ICollection`1"}.
Stack Trace:
   at FluentAssertions.Execut

Is already addressed in a different PR.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 good ratio of removals/additions 😸

@Mpdreamz Mpdreamz merged commit 00665d2 into 7.x Jun 24, 2019
@Mpdreamz Mpdreamz deleted the fix/3854 branch June 24, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants