Advance reader when not expected JSON token #3833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit advances the JSON reader when a JSON token is one that is unexpected e.g. when the JSON token is null.
Mpdreamz
approved these changes
Jun 20, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, I wonder how we can prevent forgetting this in the future.
An extension method that does return reader.AdvanceNext() and return reader.AdvanceBlock() perhaps?
Does this supersede https://github.com/elastic/elasticsearch-net/pull/3815/files ?
Contributor
Author
|
There's some overlap with #3815, although there may be one or two things in that PR that are not in this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit advances the JSON reader when a JSON token is one that is unexpected e.g. when the JSON token is null.