Use a custom convertor for GeoOrientation to tolerate alternative options in Elasticsearch #3776 #3779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions in Elasticsearch #3776
russcam
approved these changes
Jun 6, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM. Left a comment about the lowercasing
russcam
approved these changes
Jun 7, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM. Left small comment about assertion
src/Tests/Tests/Mapping/Types/Geo/GeoShape/GeoShapeClusterMetadataApiTests.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening to start a conversation on how to implement a
JsonFormatterfor anenum.OOTB it looks like UTF8JSON doesnt support placing the attribute on enum values.
Any idea where to go with this? @russcam