7x/code gen lookover #3777
Merged
7x/code gen lookover #3777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface/request/descriptor now, the non generic previously generated was only filler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went over the recent surge of code gen changes and picked up some quick wins:
If the manual request implementation only defines a single generic interface we no longer generate a non generic interface/request/descriptor to serve as the base. This alleviates some of the type overloads where we know we always only want a generic implemetation.
Generator notice files are big and bold now, hard to miss. Marks all generated files with a clear header.
You can now run
build.bat codegenfrom the command line as well.ApiUrls now has a dedicated static lookup class so that we never generate a static property in a generic class.
Generated high level methods and namespace properties now have some xmldocs.
cc @codebrain @russcam