Adds the x-pack REST API downloads into the client generator. #3637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a special case to the ApiGenerator for PutMappingDescriptor's parameterless constructor. Within, index and type should default to being inferred from generic type parameter T. This replaces the parameterless ctor that formed part of the non-generated partial class part of PutMappingDescriptor.
Update packages to latest version which includes change to allow running integration tests against 6.7.0
russcam
approved these changes
Apr 3, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM. A couple of small things to address
Contributor
|
#3638 should be merged in after this as it fixes some of the issues introduced in the new REST API specs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.