Skip to content

Conversation

@octocat-mona
Copy link

Updated Xmldocs to clarify that exceptions are not thrown for bulk actions.

Updated Xmldocs to clarify that exceptions are not thrown for bulk actions.
@ghost
Copy link

ghost commented Dec 17, 2018

Hi @KPStolk, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KPStolk thanks for submitting this PR! I think the rule is more generic then suggested note, see my review comment.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you for getting back to this!

@octocat-mona
Copy link
Author

You're welcome @Mpdreamz 😄

@octocat-mona
Copy link
Author

Hey @Mpdreamz will you merge this PR? I don't have access to do that... 😉

@Mpdreamz Mpdreamz merged commit 5db1973 into elastic:master Jan 15, 2019
@Mpdreamz
Copy link
Member

It's in now, should go out in the next release! Thanks again @KPStolk 😄

Mpdreamz added a commit that referenced this pull request Jan 28, 2019
* Document how to subclass the HttpConnection to provide authentication headers, e.g for Kerberos

* move comment about examples to the top

(cherry picked from commit 980a5df)
Mpdreamz pushed a commit that referenced this pull request Mar 29, 2019
* Updated Xmldocs

Updated Xmldocs to clarify that exceptions are not thrown for bulk actions.

* Updated ThrowExceptions XmlDocs to explicitly mark an exception for SuccessOrKnownError
Mpdreamz added a commit that referenced this pull request Mar 29, 2019
* Document how to subclass the HttpConnection to provide authentication headers, e.g for Kerberos

* move comment about examples to the top

(cherry picked from commit 980a5df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants