-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Updated Xmldocs #3518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Xmldocs #3518
Conversation
Updated Xmldocs to clarify that exceptions are not thrown for bulk actions.
Mpdreamz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KPStolk thanks for submitting this PR! I think the rule is more generic then suggested note, see my review comment.
…uccessOrKnownError
Mpdreamz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you for getting back to this!
|
You're welcome @Mpdreamz 😄 |
|
Hey @Mpdreamz will you merge this PR? I don't have access to do that... 😉 |
|
It's in now, should go out in the next release! Thanks again @KPStolk 😄 |
* Document how to subclass the HttpConnection to provide authentication headers, e.g for Kerberos * move comment about examples to the top (cherry picked from commit 980a5df)
* Updated Xmldocs Updated Xmldocs to clarify that exceptions are not thrown for bulk actions. * Updated ThrowExceptions XmlDocs to explicitly mark an exception for SuccessOrKnownError
* Document how to subclass the HttpConnection to provide authentication headers, e.g for Kerberos * move comment about examples to the top (cherry picked from commit 980a5df)
Updated Xmldocs to clarify that exceptions are not thrown for bulk actions.