Skip to content

Add uuid to indices stats #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Add uuid to indices stats #3437

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad35fb1
Add uuid to indices stats https://github.com/elastic/elasticsearch/pu…
Mpdreamz Oct 1, 2018
f2fe125
Address PR comments
russcam Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Nest/Indices/Monitoring/IndicesStats/IndicesStats.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ namespace Nest
[JsonObject]
public class IndicesStats
{
/// <summary>
/// Introduced in 6.4.0, returns the index UUID
Copy link
Contributor

@russcam russcam Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move Introduced in 6.4.0, into <remarks></remarks>?

/// </summary>
[JsonProperty("uuid")]
public string Uuid { get; }
Copy link
Contributor

@russcam russcam Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be UUID, to match elsewhere?

Copy link
Member Author

@Mpdreamz Mpdreamz Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes


[JsonProperty("primaries")]
public IndexStats Primaries { get; internal set; }

Expand Down