Add support for weighted average aggregation #3417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
suggested changes
Oct 6, 2018
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM, think the ValueType mapped as an enum would make the values more discoverable
| [JsonProperty("value_type")] | ||
| // TODO map as on server enum ? | ||
| // https://github.com/elastic/elasticsearch/blob/master/server/src/main/java/org/elasticsearch/search/aggregations/support/ValueType.java | ||
| string ValueType { get; set; } |
Contributor
There was a problem hiding this comment.
Weighted Avg Aggregation is not marked as beta or experimental, so mapping as an enum might be better, as it would help guide users as to which values are supported.
russcam
approved these changes
Oct 17, 2018
russcam
pushed a commit
that referenced
this pull request
Oct 26, 2018
This commit adds support for weighted average aggregation (cherry picked from commit fdb05e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.elastic.co/guide/en/elasticsearch/reference/6.x/search-aggregations-metrics-weight-avg-aggregation.html