[Feature] System.Text.Json support

[HarelM]

Feature request:
Support System.Text.Json writers.
More details:
Currently NEST supports Json.Net serializers. Microsoft has added a Json library to .net core 3 and a nuget package for other frameworks.
Will it be possible to use custom writers that supports System.Text.Json with NEST - I know you made a great effort to remove the JSON.net dependency, I hope this is a step forward in that aspect...
https://devblogs.microsoft.com/dotnet/try-the-new-system-text-json-apis/

[russcam]

Researching a move to System.Text.Json is on the roadmap for the future, though we don't have a timeline for when this will be.

Will it be possible to use custom writers that supports System.Text.Json with NEST

You can do this with JsonNetSerializer and Nest.JsonNetSerializer nuget package currently. It should be possible to do something similar for System.Text.Json too.

[Mpdreamz]

We started exploring this but hit some bugs in System.Text.Json that prevents us currently to move to System.Text.Json

See: #4211

[ArcadeRenegade]

I am currently switching over my project from Newtonsoft.JSON to System.Text.Json. Being able to use System.Text.Json for ElasticSearch.NET would be a nice to have as I will be able to remove Newtonsoft.JSON from my project entirely. +1

[Mpdreamz]

Once this lands: dotnet/runtime#32669
And makes its way into a prelease we can continue our open PR #4211

[HarelM]

Did someone here managed to create a IElasticsearchSerializer implementation using System.Text.Json by any chance?
I'd like to avoid doing something someone already did...

[Mpdreamz]

There is one in #4679 @HarelM

Our target version to switch over OOTB is 8.x although we are hopeful to start offering an System.Text.Json IElasticsearchSerializer as a separate package for the 7.x range of the clients as a non breaking feature.

That said there are several kinks to work out still on that PR as well as doing more performance testing work.

[HarelM]

@Mpdreamz thanks for the info!
Please note that this implementation does not allow adding custom converters as it doesn't expose the JsonSerializerOptions inner objects.
I might be missing out on something though...

[HarelM]

Also please consider the following bug I found in the existing serializer when implementing the new one: #4791
I thought about using this seriazlier since I had the following bug:
IsraelHikingMap/Site#1247
The solution was to fix the current serializer since I needed to change too much of my code in order to migrate to STJ. Never-the-less, one can learn from my experience :-)

[meywd]

Hi any update on this, I see that #4679 is merged so is the support for System.Text.Json complete?

[stevejgordon]

We are actively working on this for v8 (high-level). Already available for Low-Level.

[meywd]

@stevejgordon Thank you for the update.

[meywd]

@stevejgordon since the high level client uses the lower level one, shouldn't this be already available?