Support ES_JAVA_HOME when version > 7.12.0 #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports conditionally using the preferred ES_JAVA_HOME environment variable when the cluster version is 7.12.0 or higher. This also fixes an issue where the adduser command fails when using XPack on 7.12.0 or higher. When running on 7.12.0, a deprecation warning is printed to stdout which incorrectly triggered an exception in our code. I have specifically excluded this warning from triggering an error, although it should no longer appear since we'll use the most appropriate env var name.
I also fixed a couple of typos when I spotted them. 😄