Use plugin bat when installing on Windows #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the InstallPlugins task to use the plugin batch file as the binary when installing plugins. Previously, plugin installation used cmd as the binary, delegating to the batch file as an argument. This can cause issues where a plugin writes warnings to stderr, such as ingest-attachmeent, which triggers the InstallPlugins task to throw an exception. Remove IsMono property and replace with IsWindows property, using RuntimeInformation. Ultimately, this property is used to determine the platform running on, specifically whether Windows or not.
Contributor
Author
|
I'm going to merge this in, to unblock efforts on https://github.com/elastic/elasticsearch-net |
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 11, 2019
Relates: elastic/elasticsearch-net-abstractions#23 This commit updates the Elastic Abstractions packages
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 11, 2019
Relates: elastic/elasticsearch-net-abstractions#23 This commit updates the Elastic Abstractions packages
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Oct 11, 2019
Relates: elastic/elasticsearch-net-abstractions#23 This commit updates the Elastic Abstractions packages (cherry picked from commit cb97bc4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the InstallPlugins task to use the plugin batch file as the binary when installing plugins. Previously,
plugin installation used cmd as the binary, delegating to the batch file as an argument. This can cause issues where a plugin
writes warnings to stderr, such as ingest-attachmeent, which triggers the InstallPlugins task to throw an exception.
Remove IsMono property and replace with IsWindows property, using RuntimeInformation. Ultimately, this property is used to determine
the platform running on, specifically whether Windows or not.