Fix CI failures due to Hadoop Distro #1371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
requested changes
Oct 24, 2019
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
I left a couple of comments, I think this code could be simplified, or else a default: clause added to be explicit.
| break | ||
|
|
||
| default: | ||
| case "hadoopStable": |
Member
There was a problem hiding this comment.
We should add a default: case and throw an error, so we don't accidentally introduce leniency in the future
| case "hadoopStable": | ||
| String version = project.hadoop22Version | ||
| project.rootProject.ext.hadoopVersion = version | ||
| project.rootProject.ext.hadoopClient = ["org.apache.hadoop:hadoop-client:$version"] |
Member
There was a problem hiding this comment.
There's no difference in the code of the two different switch paths other than the println, can we move the settings out? Unless we need to not set them in the 'default' case (in which case we should be explicit in that)
dakrone
approved these changes
Oct 24, 2019
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, hooboy I had to stare at project.hadoop2Version and project.hadoop22Version for a while to see the difference :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI jobs run with the
-Pdistro=hadoopYarnsetting, which changes the Hadoop dependency at runtime to 2.7 instead of 2.2. This causes the CI jobs to fail because the SHA files for the dependency to not match the new dependencies. This PR switches the default hadoop distro used for building to be consistent with the one used in CI.