Remove crashedNodes and make primary promotion non-deterministic #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly keeping track of the crashed nodes blows up the state space that is explored by the model checker. Instead of explicitly having nodes marked as crashed, the other transition relations allow such nodes to (implicitly) just not react to any messages. This commit also changes primary promotion to non-deterministically choose a replica (using the "exists" quantifier instead of the "CHOOSE" operator).
abeyad
approved these changes
Apr 25, 2017
Contributor
abeyad
left a comment
abeyad
left a comment
There was a problem hiding this comment.
LGTM, nice simplification
Contributor
Author
|
Thanks @abeyad |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch-formal-models
that referenced
this pull request
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly keeping track of the crashed nodes blows up the state space that is explored by the model checker. Instead of explicitly having nodes marked as crashed, the other transition relations allow such nodes to (implicitly) just not react to any messages.
This commit also changes primary promotion to non-deterministically choose a replica (using the "exists" quantifier instead of the "CHOOSE" operator).
With the updated state constraint, model checking takes 3 hours on my machine.