-
Notifications
You must be signed in to change notification settings - Fork 450
Reset readme, now that docs will be on official website #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Reviewers can navigate this new readme and other files at https://github.com/webmat/ecs/tree/readme-redirect |
|
What is the reason you keep all the old files around? Can't we just delete them and in case we need them again we use git? |
CHANGELOG.next.md
Outdated
| ### Deprecated | ||
|
|
||
| * Move old `fields.yml` file from the root of the repo to `generated/legacy`. #386 | ||
| * Move the old all-in-one README.md to generated/legacy/. #395 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not put changing docs into the README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree in principle. However I thought since the official ECS reference used to be this file, it's disappearance was worth a mention in the changelog
|
Yeah I was on the fence on the old files. I'll delete them and all of the code associated. |
- point to the official docs - point to contributor-centric documentation
Rename ECS intermediary files to match the variables in the generator code
Also re-introduce generator for legacy readme
|
Old readme is now deleted. I'll get rid of the other generated files in another PR, since this PR is meant to be one of the concrete steps of the asciidoc deployment to the main site. I don't want it to contain too much. |
|
This PR was getting a bit too big for my taste, for something that should be done on the day of the deployment to the main website. I'm closing it in favour of the trimmed down #400 |
This PR has been replaced by #400
In this PR:
TODO
generated/legacyfor now