Skip to content

ECS formatter for JUL (java.util.logging) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2020
Merged

ECS formatter for JUL (java.util.logging) #69

merged 4 commits into from
Apr 7, 2020

Conversation

redrathnure
Copy link
Contributor

related to #68 discussion.

Current state:

  • it works! Filebeat successfully exports Tomcat logs and Kibana shows well structured records.
  • No thread name avialable, just thread ID (JUL design limitation)
  • No MDC and NDC (JUL design limitation)
  • origin do not have valie line number (JUL design limitation)

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 3, 2020 •
edited
Loading

💚 CLA has been signed

felixbarny
felixbarny requested changes Apr 6, 2020
View reviewed changes
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

A few changes and it should be good to go 👍

@felixbarny felixbarny linked an issue Apr 6, 2020 that may be closed by this pull request
ECS formatter for JUL (java.util.logging) #68
Closed
@redrathnure @felixbarny
fix: review issues;
fb2ed45 
Co-Authored-By: Felix Barnsteiner <[email protected]>
@redrathnure redrathnure force-pushed the feature-jul-formatter branch from f6df762 to fb2ed45 Compare April 7, 2020 00:07
@felixbarny
Copy link
Member

There are some errors in the tests: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-java%2Fecs-logging-java-mbp/detail/PR-69/11/pipeline

@felixbarny felixbarny merged commit 5b19736 into elastic:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixbarny felixbarny felixbarny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECS formatter for JUL (java.util.logging)
2 participants
@redrathnure @felixbarny