-
Notifications
You must be signed in to change notification settings - Fork 81
Description
This may seem like nitpicking, but I am sensitive to stuff like this and I think it really makes the JSON harder to read for humans:
I am evaluating co.elastic.logging:logback-ecs-encoder:1.3.2
as a replacement for the logstash-encoder. It seems to work well, but... The encoder uses inconsistent whitespace after the comma character after each key-value-pair.
Example:
{"@timestamp":"2022-03-21T18:31:40.855Z", "log.level": "INFO", "message":"Start creating calculation modules from configuration ...", "ecs.version": "1.2.0","process.thread.name":"main","log.logger":"my.company.modules.factory.ModuleFactory"}
As you can see, there is a space-character after the values for the @timestamp
, the log.level
the message
value, but not after the values for ecs.version
and process.thread.name
.
Again, this seems like a really small thing, but it also makes a bad first impression, especially since this format is advertised as a "Decently human-readable JSON structure" (https://www.elastic.co/guide/en/ecs-logging/overview/current/intro.html#_why_ecs_logging)