Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented May 28, 2019

This PR adds shared attributes for the terms "Elastic Cloud" and "Elasticsearch Service", as well as ESMS and data frames so they can be used consistently across the library.

@lcawl lcawl requested a review from nrichers May 28, 2019 20:06
Copy link
Contributor

@kellyemurphy kellyemurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit f8f3bbf into elastic:master May 30, 2019
@lcawl lcawl deleted the cloud-attributes branch May 30, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants