Asciidoctor: Copy inline images in lists #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for copying inline images declared in lists. Sadly, Asciidoctor doesn't make this easy. They pre-convert lists so we have to detect the image in docbook. I feel like it might have been a mistake to try and copy images by traversing the tree, mostly because Asciidoctor works in strange ways.
Member
Author
|
I noticed this when working on converting Kibana's book to Asciidoctor. |
This was referenced Apr 22, 2019
estolfo
requested changes
Apr 30, 2019
Contributor
estolfo
left a comment
estolfo
left a comment
There was a problem hiding this comment.
very minor if statement comment
| process_inline_image_from_source block, block.source if block.content_model == :simple | ||
| process_inline_image_from_converted block, block.text if | ||
| block.context == :list_item && block.parent.context == :olist | ||
| end |
Contributor
There was a problem hiding this comment.
You might want to reverse the syntax and write the if statement first.
I typically only use the post-fix if statement if it fits on one line and is fairly simple logic.
|
|
||
| ## | ||
| # Scan the inline image from the generated docbook. It is not nice that | ||
| # this is required there isn't much we can do about it. We *could* rewrite |
Contributor
There was a problem hiding this comment.
Maybe missing the word 'so'..?
Member
Author
|
@esdocs, I've fixed this up from your comments and reworked it to be a bit more consistent with itself. |
Member
Author
|
@estolfo, I've fixed this up from your comments and reworked it a big to be more consistent. Could you have another look? |
Member
Author
|
Thanks so much for reviewing @estolfo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for copying inline images declared in lists. Sadly,
Asciidoctor doesn't make this easy. They pre-convert lists so we have to
detect the image in docbook. I feel like it might have been a mistake to
try and copy images by traversing the tree, mostly because Asciidoctor
works in strange ways.