Skip to content

Conversation

@trentm
Copy link
Member

@trentm trentm commented Sep 1, 2023

This also drops hosting the ancient 0.x version of the apm-agent-nodejs docs.

This also *drops* hosting the ancient 0.x, 1.x, and 2.x versions of the apm-agent-nodejs docs.
@trentm trentm self-assigned this Sep 1, 2023
@trentm trentm mentioned this pull request Sep 1, 2023
24 tasks
@bmorelli25
Copy link
Member

Ah, the 4.x branch doesn't exist yet. The docs ci check will fail until it does.

17:52:06 INFO:build_docs:Error executing: git archive --format=tar -o /tmp/docsbuild/iKrWzqBjLA/apm-agent-nodejs/.temp_git_archive.tar 4.x docs in GIT_DIR /docs_build/.repos/apm-agent-nodejs.git

@trentm
Copy link
Member Author

trentm commented Sep 1, 2023

Ah, the 4.x branch doesn't exist yet.

Yah, I'll have one in a little bit. I couldn't create a temporary one from our "dev/4.x" branch because it has merge commits that our branch protections disallow.

@trentm
Copy link
Member Author

trentm commented Sep 5, 2023

Yah, I'll have one in a little bit.

That took more than a little bit. There is a 4.x branch now.

@trentm
Copy link
Member Author

trentm commented Sep 5, 2023

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

I pushed an update that changes how some stack versions will link to the Node.js docs. In addition, we'll need to update the Node.js docs version for a few older stack versions:

:apm-node-branch: 1.x

:apm-node-branch: 1.x

:apm-node-branch: 2.x

Can these be bumped to 3.x? If they remain unchanged, the build will fail with the removal of the 1.x and 2.x branches.

@trentm
Copy link
Member Author

trentm commented Sep 5, 2023

Can these be bumped to 3.x?

Hrm, I'm guessing not. Both 3.x and 4.x of the Node.js APM agent are documented to only support back to APM Server v6.6.

Do you know if we need to have links to online docs for versions of the APM agents for 6.3, 6.4, 6.5? Do we still support those versions of the stack?

In any case, this change is not an appropriate one to have a cascade of dropping docs for earlier version of the stack, so we could put the 1.x and 2.x docs back in if that is easiest. (Though they are obsolete and completely unsupported.)

What is easiest here?

@trentm
Copy link
Member Author

trentm commented Sep 5, 2023

I guess we could drop the 0.x docs at least.

@trentm
Copy link
Member Author

trentm commented Sep 5, 2023

@bmorelli25 Also, what do you think about pointing to apm-node-branch 4.x for the 7.x versions of the stack as well?

@trentm
Copy link
Member Author

trentm commented Sep 5, 2023

Also the 2.x here seems wrong:

shared/versions/stack/7.4.asciidoc
28::apm-node-branch:       3.x

shared/versions/stack/7.5.asciidoc
28::apm-node-branch:       2.x

@bmorelli25
Copy link
Member

@bmorelli25 Also, what do you think about pointing to apm-node-branch 4.x for the 7.x versions of the stack as well?

Yes, definitely. I wasn't sure on compatibility when I pushed my original commit.

Both 3.x and 4.x of the Node.js APM agent are documented to only support back to APM Server v6.6.

Should we bring 4.x all the way back to 6.6 then?

Do you know if we need to have links to online docs for versions of the APM agents for 6.3, 6.4, 6.5? Do we still support those versions of the stack?

We do not support these versions of the stack anymore, but we do have to continue publishing documentation for them. Unfortunately, our doc build doesn't support version-specific link checking, so we also have to maintain links between older versions.

I guess we could drop the 0.x docs at least.

Agreed.

In any case, this change is not an appropriate one to have a cascade of dropping docs for earlier version of the stack, so we could put the 1.x and 2.x docs back in if that is easiest. (Though they are obsolete and completely unsupported.)

Is 2.x supported by 6.3 and 6.4? If so, we could also get rid of v1.x of the agent.

@trentm
Copy link
Member Author

trentm commented Sep 5, 2023

Should we bring 4.x all the way back to 6.6 then?

Yes.

Is 2.x supported by 6.3 and 6.4? If so, we could also get rid of v1.x of the agent.

https://www.elastic.co/guide/en/apm/agent/nodejs/2.x/supported-technologies.html#elastic-stack-compatibility
says "This agent is compatible with APM Server v6.5 and above. For support for previous releases of the APM Server, use version 1.x of the agent."

... so I think we are stuck with publishing the 1.x docs as well for 6.4 and below.

https://www.elastic.co/guide/en/apm/agent/nodejs/1.x/compatibility.html#elastic-stack-compatibility says "Version 1.x of the agent is compatible with APM Server v6.2 to v6.4."

@bmorelli25
Copy link
Member

Pushing a change to fix the build...

@bmorelli25
Copy link
Member

Nice. The build succeeded. Here's a preview link for the new 4.x docs.

@trentm
Copy link
Member Author

trentm commented Sep 5, 2023

The build succeeded.

Nice, thanks. So I should take this out of draft and get it merged right after we've done the first 4.x release and updated our "4.x" branch, right?

@bmorelli25
Copy link
Member

That's correct.

  1. Take out of draft
  2. I'll approve
  3. Release the 4.x version
  4. Merge this PR
  5. Ask @bmorelli25 to kick off a full rebuild of the Elastic documentation site in Jenkins (takes ~ 70 mins)
  6. Docs are live!

@trentm trentm marked this pull request as ready for review September 6, 2023 18:03
@trentm trentm requested a review from bmorelli25 September 6, 2023 18:03
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@bmorelli25 bmorelli25 merged commit aad4349 into master Sep 7, 2023
@bmorelli25 bmorelli25 deleted the trentm/apm-agent-nodejs-4 branch September 7, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants