-
Notifications
You must be signed in to change notification settings - Fork 347
Update for a coming apm-agent-nodejs 4.x stream #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also *drops* hosting the ancient 0.x, 1.x, and 2.x versions of the apm-agent-nodejs docs.
|
Ah, the |
Yah, I'll have one in a little bit. I couldn't create a temporary one from our "dev/4.x" branch because it has merge commits that our branch protections disallow. |
That took more than a little bit. There is a 4.x branch now. |
|
@elasticmachine, run elasticsearch-ci/docs |
|
I pushed an update that changes how some stack versions will link to the Node.js docs. In addition, we'll need to update the Node.js docs version for a few older stack versions: docs/shared/versions/stack/6.3.asciidoc Line 21 in 303232e
docs/shared/versions/stack/6.4.asciidoc Line 21 in 303232e
docs/shared/versions/stack/6.5.asciidoc Line 23 in 303232e
Can these be bumped to |
Hrm, I'm guessing not. Both 3.x and 4.x of the Node.js APM agent are documented to only support back to APM Server v6.6. Do you know if we need to have links to online docs for versions of the APM agents for 6.3, 6.4, 6.5? Do we still support those versions of the stack? In any case, this change is not an appropriate one to have a cascade of dropping docs for earlier version of the stack, so we could put the 1.x and 2.x docs back in if that is easiest. (Though they are obsolete and completely unsupported.) What is easiest here? |
|
I guess we could drop the 0.x docs at least. |
|
@bmorelli25 Also, what do you think about pointing to apm-node-branch 4.x for the 7.x versions of the stack as well? |
|
Also the 2.x here seems wrong: |
Yes, definitely. I wasn't sure on compatibility when I pushed my original commit.
Should we bring 4.x all the way back to 6.6 then?
We do not support these versions of the stack anymore, but we do have to continue publishing documentation for them. Unfortunately, our doc build doesn't support version-specific link checking, so we also have to maintain links between older versions.
Agreed.
Is 2.x supported by 6.3 and 6.4? If so, we could also get rid of v1.x of the agent. |
Yes.
https://www.elastic.co/guide/en/apm/agent/nodejs/2.x/supported-technologies.html#elastic-stack-compatibility ... so I think we are stuck with publishing the 1.x docs as well for 6.4 and below. https://www.elastic.co/guide/en/apm/agent/nodejs/1.x/compatibility.html#elastic-stack-compatibility says "Version 1.x of the agent is compatible with APM Server v6.2 to v6.4." |
|
Pushing a change to fix the build... |
|
Nice. The build succeeded. Here's a preview link for the new |
Nice, thanks. So I should take this out of draft and get it merged right after we've done the first 4.x release and updated our "4.x" branch, right? |
|
That's correct.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This also drops hosting the ancient 0.x version of the apm-agent-nodejs docs.