set current branch of apm-agent-python to "1.x" #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just saw an email from @drewr regarding slashes in branch names. Could this be a problem here? |
Contributor
Author
|
I renamed the branch from |
beniwohli
changed the title
Contributor
|
As a general rule, we've gone to publishing docs for upcoming releases in addition to the "current" release. I'd switch this to: Either way, as long as it builds locally with your changes, LGTM. |
Contributor
Author
|
Sounds good, thanks! I'll try and build it with all three branches locally, and merge if it works as expected |
The master branch will see some incompatibilities landed between now and 6.2 (when APM goes GA). This should avoid that those compatibilities land on https://www.elastic.co/guide/en/apm/agent/python/current/index.html before GA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The master branch will see some incompatibilities landed between
now and 6.2 (when APM goes GA). This should avoid that those
incompatibilities land on
https://www.elastic.co/guide/en/apm/agent/python/current/index.html
before GA.