Skip to content

Conversation

@jrodewig
Copy link
Contributor

IMPORTANT: DO NOT MERGE UNTIL AUG 31, 2023

Updates the UTM parameters used to track Cloud trial signups from the docs.

Per Marketing, the old parameter keys (baymax, elektra) are outdated: https://elastic.slack.com/archives/C01AA2TLEUX/p1691580994671689 (Sorry — internal link only)

@jrodewig jrodewig marked this pull request as ready for review August 30, 2023 13:03
@jrodewig jrodewig requested a review from a team August 30, 2023 13:03
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work as-is. Please see my comment about defining and setting the query param variables before you define and set the URL variables.

@jrodewig jrodewig requested a review from bmorelli25 August 30, 2023 17:30
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@jrodewig jrodewig merged commit 2514d1b into elastic:master Aug 31, 2023
@jrodewig jrodewig deleted the jrodewig/update-utm-params branch August 31, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants