Add APM Guide #2246
Merged
Add APM Guide #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtback
requested changes
Oct 13, 2021
Member
gtback
left a comment
gtback
left a comment
There was a problem hiding this comment.
Overall, LGTM. It seems like the plan you have described in elastic/apm-server#6287 makes sense. Changing the chunk level can have unexpected consequences, but it seems like you've prepared for those.
Co-authored-by: Greg Back <[email protected]>
bmorelli25
commented
Oct 13, 2021
bmorelli25
commented
Oct 15, 2021
bmorelli25
commented
Oct 15, 2021
bmorelli25
commented
Oct 15, 2021
Revert chunk level change on deprecated books
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change chunk level of APM Server Reference and APM OverviewRevertedMERGE AFTER elastic/apm-server#6287