Skip to content

Conversation

@bmorelli25
Copy link
Member

Summary

Per conversation with Silvia, this PR adds issues labeled, Team:Docs to the Observability Docs project board.

One thing we might want to discuss is whether you still want documentation issues to be added to the APM Server team board. If no changes are made to the other workflow, Team:Docs issues will be added to both.

@bmorelli25 bmorelli25 requested a review from simitt July 13, 2022 22:49
@bmorelli25 bmorelli25 self-assigned this Jul 13, 2022
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jul 13, 2022
@elastic elastic deleted a comment from mergify bot Jul 13, 2022
@ghost
Copy link

ghost commented Jul 13, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T08:08:11.433+0000

  • Duration: 31 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 4109
Skipped 13
Total 4122

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost
Copy link

ghost commented Jul 13, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (42/42) 💚
Files 91.96% (183/199) 👍
Classes 93.435% (427/457) 👍
Methods 89.163% (1086/1218) 👍 0.082
Lines 76.822% (13321/17340) 👍 0.012
Conditionals 100.0% (0/0) 💚

@ghost
Copy link

ghost commented Jul 13, 2022

📚 Go benchmark report

Diff with the main branch

name                                                                                            old time/op    new time/op     delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/invalid-metadata-2.ndjson-12                                                     2.46µs ± 0%     2.42µs ± 1%   -1.43%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-json-metadata.ndjson-12       1.77µs ± 0%     1.78µs ± 0%   +0.50%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/metadata-null-values.ndjson-12        1.07µs ± 1%     1.09µs ± 3%   +2.55%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/minimal.ndjson-12                     7.98µs ± 1%     7.73µs ± 2%   -3.15%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions_spans_rum.ndjson-12      2.26µs ± 1%     2.28µs ± 1%   +0.80%  (p=0.040 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/minimal-service.ndjson-12             5.84µs ±12%     5.01µs ± 6%  -14.17%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/minimal.ndjson-12                     16.0µs ± 9%     18.3µs ±14%  +14.54%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-event.ndjson-12          3.36µs ± 8%     3.04µs ± 8%   -9.79%  (p=0.040 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions_spans.ndjson-12          33.4µs ± 7%     30.9µs ± 4%   -7.48%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/invalid-json-event.ndjson-12          1.65µs ± 1%     1.67µs ± 2%   +1.45%  (p=0.040 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/metricsets.ndjson-12                  7.94µs ± 7%     7.48µs ± 1%   -5.81%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/span-links.ndjson-12                  2.75µs ± 3%     2.61µs ± 5%   -5.01%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                            old alloc/op   new alloc/op    delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
CompressedRequestReader/deflate_content_encoding-12                                               45.0kB ± 0%     45.0kB ± 0%   +0.12%  (p=0.024 n=5+5)
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-metadata.ndjson-12            3.60kB ± 0%     3.64kB ± 1%   +1.23%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/minimal.ndjson-12                     39.5kB ± 0%     39.7kB ± 0%   +0.48%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/metricsets.ndjson-12                  32.2kB ± 0%     31.9kB ± 0%   -0.76%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/minimal.ndjson-12                     39.6kB ± 0%     39.3kB ± 1%   -0.82%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/metricsets.ndjson-12                  32.6kB ± 1%     32.1kB ± 1%   -1.32%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/minimal.ndjson-12                     38.7kB ± 0%     38.9kB ± 0%   +0.50%  (p=0.016 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/json_codec/399_events-12                                                               1.55MB ± 0%     1.55MB ± 0%   -0.21%  (p=0.040 n=5+5)
ReadEvents/json_codec_big_tx/10_events-12                                                         94.6kB ± 0%     94.6kB ± 0%   -0.06%  (p=0.016 n=5+5)

name                                                                                            old allocs/op  new allocs/op   delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/decoder goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/errors.ndjson-12                         461 ± 0%        462 ± 0%   +0.22%  (p=0.029 n=4+4)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64

name                                                                                            old speed      new speed       delta
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/invalid-metadata-2.ndjson-12                                                    178MB/s ± 0%    180MB/s ± 1%   +1.46%  (p=0.008 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/invalid-json-metadata.ndjson-12      253MB/s ± 0%    251MB/s ± 0%   -0.49%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/metadata-null-values.ndjson-12       493MB/s ± 1%    481MB/s ± 3%   -2.44%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/minimal.ndjson-12                    129MB/s ± 1%    133MB/s ± 2%   +3.25%  (p=0.016 n=4+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel0/transactions_spans_rum.ndjson-12     510MB/s ± 1%    506MB/s ± 1%   -0.79%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/minimal-service.ndjson-12           73.3MB/s ±13%   84.9MB/s ± 6%  +15.87%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel2/minimal.ndjson-12                   64.7MB/s ± 9%   56.6MB/s ±13%  -12.51%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/invalid-json-event.ndjson-12         175MB/s ± 8%    194MB/s ± 8%  +10.82%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel4/transactions_spans.ndjson-12         175MB/s ± 7%    189MB/s ± 4%   +7.97%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/invalid-json-event.ndjson-12         357MB/s ± 1%    352MB/s ± 2%   -1.41%  (p=0.032 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/metricsets.ndjson-12                 321MB/s ± 6%    341MB/s ± 1%   +6.02%  (p=0.016 n=5+5)
BackendProcessorParallel/BenchmarkBackendProcessorParallel8/span-links.ndjson-12                 248MB/s ± 3%    262MB/s ± 5%   +5.37%  (p=0.032 n=5+5)

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we might want to discuss is whether you still want documentation issues to be added to the APM Server team board. If no changes are made to the other workflow, Team:Docs issues will be added to both.

We filter them out in our regular APM Server board view, so I don't believe we need them in the board, but they are also not interfering with anything at this point.

@bmorelli25
Copy link
Member Author

Sounds good!

@bmorelli25 bmorelli25 merged commit e955205 into elastic:main Jul 18, 2022
@bmorelli25 bmorelli25 deleted the add-obs-docs-automation branch July 18, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation backport-skip Skip notification from the automated backport with mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants