Skip to content

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Jan 4, 2022

Summary

Sources AWS Lambda extension docs from the elastic/apm-aws-lambda repo instead of copy/pasting them.

Closes https://github.com/elastic/observability-docs/issues/1132.

Note

The new command to build the APM Guide docs is:

 $GIT_HOME/docs/build_docs --doc $GIT_HOME/apm-server/docs/integrations-index.asciidoc --resource=$GIT_HOME/observability-docs/ --resource=$GIT_HOME/apm-aws-lambda/ --chunk 2 --open

@bmorelli25 bmorelli25 added Team:Docs Label for the Observability docs team backport-7.16 Automated backport with mergify to the 7.16 branch backport-8.0 Automated backport with mergify backport-7.17 Automated backport with mergify to the 7.17 branch labels Jan 4, 2022
@bmorelli25 bmorelli25 requested review from a team and astorm January 4, 2022 20:36
@bmorelli25 bmorelli25 self-assigned this Jan 4, 2022
@bmorelli25
Copy link
Member Author

@astorm — apologies that this took so long. The only thing left is to create 8.0, 7.17, and 7.16 branches in the apm-aws-lamda repo and to backport the docs directory to those branches. I can take care of this if you'd like!

@ghost
Copy link

ghost commented Jan 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-04T20:36:57.510+0000

  • Duration: 43 min 43 sec

  • Commit: cf2f858

Test stats 🧪

Test Results
Failed 0
Passed 5621
Skipped 19
Total 5640

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like you just need to update the branch.

@astorm
Copy link
Contributor

astorm commented Jan 6, 2022

Thanks @bmorelli25! Re:

The only thing left is to create 8.0, 7.17, and 7.16 branches in the apm-aws-lamda repo and to backport the docs directory to those branches. I can take care of this if you'd like!

Yes, if you could do and that, as well as capture what was done somewhere so we can do it for future releases, that would be great.

Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bmorelli25 bmorelli25 merged commit 16aafd5 into elastic:master Jan 6, 2022
@bmorelli25 bmorelli25 deleted the add-aws-docs branch January 6, 2022 19:58
mergify bot pushed a commit that referenced this pull request Jan 6, 2022
mergify bot pushed a commit that referenced this pull request Jan 6, 2022
mergify bot pushed a commit that referenced this pull request Jan 6, 2022
bmorelli25 added a commit that referenced this pull request Jan 7, 2022
(cherry picked from commit 16aafd5)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Jan 7, 2022
(cherry picked from commit 16aafd5)

Co-authored-by: Brandon Morelli <[email protected]>
bmorelli25 added a commit that referenced this pull request Jan 7, 2022
(cherry picked from commit 16aafd5)

Co-authored-by: Brandon Morelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-7.16 Automated backport with mergify to the 7.16 branch backport-7.17 Automated backport with mergify to the 7.17 branch backport-8.0 Automated backport with mergify Team:Docs Label for the Observability docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request] "APM Overview -> Features -> Lambda Extension" Page

3 participants