Introduce elasticsearch.Error #3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
elasticsearch-error-responses
branch
from
83386d3 to
66739e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
+ Coverage 78.87% 79.15% +0.28%
==========================================
Files 106 106
Lines 5600 5609 +9
==========================================
+ Hits 4417 4440 +23
+ Misses 1183 1169 -14
|
Elasticsearch operations that use "doRequest" will now return an *elasticsearch.Error if the server responds with a status code > 299. The error type can be used for special handling of certain status codes, such as 401 Unauthorized when performing _has_privileges checks. The API Key auth code is updated to cache 401 responses using this type and `errors.As`, checking for 401s. Similarly, the apikey CLI subcommand now checks for 404s specifically for ignoring failed privilege deletions.
axw
force-pushed
the
elasticsearch-error-responses
branch
from
66739e4 to
7f40a99
Compare
Member
Author
|
Integration tests failed because apm-integration-testing is attempting to build apm-server using Go 1.12. Opened elastic/apm-integration-testing#720 |
simitt
approved these changes
Jan 21, 2020
Member
Author
|
Jenkins run the tests please |
axw
added a commit
to axw/apm-server
that referenced
this pull request
Jan 21, 2020
Elasticsearch operations that use "doRequest" will now return an *elasticsearch.Error if the server responds with a status code > 299. The error type can be used for special handling of certain status codes, such as 401 Unauthorized when performing _has_privileges checks. The API Key auth code is updated to cache 401 responses using this type and `errors.As`, checking for 401s. Similarly, the apikey CLI subcommand now checks for 404s specifically for ignoring failed privilege deletions.
axw
added a commit
to axw/apm-server
that referenced
this pull request
Jan 21, 2020
Elasticsearch operations that use "doRequest" will now return an *elasticsearch.Error if the server responds with a status code > 299. The error type can be used for special handling of certain status codes, such as 401 Unauthorized when performing _has_privileges checks. The API Key auth code is updated to cache 401 responses using this type and `errors.As`, checking for 401s. Similarly, the apikey CLI subcommand now checks for 404s specifically for ignoring failed privilege deletions.
axw
added a commit
that referenced
this pull request
Jan 21, 2020
Elasticsearch operations that use "doRequest" will now return an *elasticsearch.Error if the server responds with a status code > 299. The error type can be used for special handling of certain status codes, such as 401 Unauthorized when performing _has_privileges checks. The API Key auth code is updated to cache 401 responses using this type and `errors.As`, checking for 401s. Similarly, the apikey CLI subcommand now checks for 404s specifically for ignoring failed privilege deletions.
axw
added a commit
that referenced
this pull request
Jan 21, 2020
Elasticsearch operations that use "doRequest" will now return an *elasticsearch.Error if the server responds with a status code > 299. The error type can be used for special handling of certain status codes, such as 401 Unauthorized when performing _has_privileges checks. The API Key auth code is updated to cache 401 responses using this type and `errors.As`, checking for 401s. Similarly, the apikey CLI subcommand now checks for 404s specifically for ignoring failed privilege deletions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch operations that use "doRequest" will now
return an *elasticsearch.Error if the server responds
with a status code > 299. The error type can be used
for special handling of certain status codes, such as
401 Unauthorized when performing _has_privileges checks.
The API Key auth code is updated to cache 401 responses
using this type and
errors.As, checking for 401s.Similarly, the apikey CLI subcommand now checks for 404s
specifically for ignoring failed privilege deletions.
Fixes #3215